Remove unused _pow10_label helper from pyplot axes - #368
Open
aymuos15 wants to merge 1 commit into
Open
Conversation
_pow10_label was a one-line wrapper over _pow_label(value, 10.0) with no call sites; log-decade labelling goes through _pow_label directly with the base pulled from the tick spec.
📝 WalkthroughWalkthroughRemoved the module-level ChangesAxes label helper cleanup
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Merging this PR will not alter performance
Comparing 
Footnotes
|
Contributor
Author
|
Seems to be another flaky case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_pow10_labelinpython/xy/pyplot/_axes.pywas a one-line wrapper over_pow_label(value, 10.0)with no call sites anywhere inpython/,tests/,scripts/,js/, ordocs/.Axes._apply_tickersalready calls_pow_labeldirectly with the base pulled from the tick spec (_pow_label(value, float(spec.get("base", 10.0)))), so the hardcoded-base wrapper had been superseded.